Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized search view rendering #695

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - list issue(s) here
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

This PR addresses navigation back to the new search view being extremely choppy due to reloadRecentSearches triggering a view redraw for every single search. They are now accumulated into a temporary array and updated all at once.

@EricBAndrews EricBAndrews requested a review from a team as a code owner October 4, 2023 02:55
@EricBAndrews EricBAndrews requested review from WestonHanners and mormaer and removed request for a team October 4, 2023 02:55
@EricBAndrews EricBAndrews changed the title Optimized search view loading Optimized search view rendering Oct 4, 2023
Copy link
Member

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@EricBAndrews EricBAndrews merged commit fb3ebb3 into dev Oct 4, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/search-navigation-tuneup branch October 4, 2023 12:01
boscojwho added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants